[FRONTEND][TF] Add conv3d #4604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
reviewed
Dec 31, 2019
masahi
approved these changes
Jan 1, 2020
|
Thanks @optima2005 |
icemelon
reviewed
Jan 6, 2020
|
|
||
| def _callback(op): | ||
| if op.tag == 'conv3d_ndhwc': | ||
| schedule_direct_3d_cuda(cfg, s, op.output(0)) |
There was a problem hiding this comment.
@optima2005 @masahi
I have one question here. It seems that schedule_direct_3d_cuda only supports NCDHW. So here invoking schedule_direct_3d_cuda looks incorrect. Could you double check on this? correct me if I'm wrong.
There was a problem hiding this comment.
ping @optima2005 can you comment?
There was a problem hiding this comment.
@icemelon9 You are correct. I made a mistake here. Sorry about that.
Just like NHWC for conv2d, The NDHWC layout conv3d won't be supported for cuda. So the schedule won't be needed. I would remove it by raising a new PR.
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 26, 2020
* [FRONTEND][TF] Add conv3d * fix high rtol
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 28, 2020
* [FRONTEND][TF] Add conv3d * fix high rtol
zhiics
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2020
* [FRONTEND][TF] Add conv3d * fix high rtol
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of attempts to implement #4009
This PR is to add conv3d to TF frontend.
@masahi